Fix CI jobs #12
Merged
Fix CI jobs #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aschepis
commented
May 1, 2024
aschepis
commented
- fix linter ci job
- fix test ci step
- add test-generate make target
- fix check for clean worktree
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
aschepis
force-pushed
the
aschepis/test-generate-code
branch
from
68ba777
to
ac36ee7
Compare
aschepis
force-pushed
the
aschepis/test-generate-code
branch
2 times, most recently
from
7bc5709
to
b855435
Compare
aschepis
force-pushed
the
aschepis/test-generate-code
branch
from
b855435
to
c94998b
Compare
prashantv
approved these changes
May 2, 2024
Comment on lines
-37
to
-38
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
it does work and we use it for some other jobs, but for linting we don't need to check out the history. we just need the commit. this is also related to why we disarm the go:embed stuff. We can just lint the code without having to build the provider and generate code, etc.
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.21 | ||
| cache: false | ||
| - name: disarm go:embed directives to enable lint |
There was a problem hiding this comment.
can you add a comment for why we're doing this
.github/workflows/ci.yml
Outdated
| @@ -132,7 +124,8 @@ jobs: | |||
| gradle-version: ${{ env.GRADLEVERSION }} | |||
| - name: Build SDK | |||
| run: make provider build_${{ matrix.language }} | |||
| # TODO: Check worktree clean | |||
| - name: Check worktree clean | |||
There was a problem hiding this comment.
maybe "Check generated code is upto date"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.